etaler / PyEtaler

The offical Python binding for Etaler via cppyy
BSD 3-Clause "New" or "Revised" License
10 stars 1 forks source link

Windows/MSVC support #3

Open marty1885 opened 4 years ago

marty1885 commented 4 years ago

PyEtaler does not build correctly on Windows with MSVC

  1. cppyy on Windows seems doesn't enable C++17 support by default
  2. The compilation commands in genbinding.py is geared towards GCC and clang. MSVC won't accept the parameters.

The first problem is easy enough to fix (by appending flags). But the second one need some experiment. MSVC have a different set of parameters and naming convention.

Log: https://pastebin.com/Qcwf952b