search

etamity / apple-http-osmf

Automatically exported from code.google.com/p/apple-http-osmf
0 stars 0 forks source link

https absolute url support broken in HLS manifests #26

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
Simple bug, with a one byte fix.

What steps will reproduce the problem?
1. play an HLS manifest with absolute HTTPS URLS in it
2.
3.

What is the expected output? What do you see instead?
Expected: video plays
Actual: Error: "This manifest handler does not understand indexInfo that does 
not appear to be a URL"

What version of the product are you using? On what operating system?
trunk (r11), custom build (direct linking into flowplayer httpstreaming-hls 
plugin)

Please provide any additional information below.
Looks like no one actually ran this code path after writing it, in 
HTTPStreamingM3U8IndexHandler.  The second indexOf comparison should be !=, as 
is the first, not "==".  On a related note: the handling of absolute, normal 
HTTP urls seems to work as intended.   

                       if(_indexString.toLowerCase().indexOf("http://") != 0 && _indexString.toLowerCase().indexOf("https://") == 0)
                                throw new Error("This manifest handler does not understand indexInfo that does not appear to be a URL");

I've patched this locally, but wanted to record the bug officially, and thank 
everyone for the work on this project.

Original issue reported on code.google.com by greg.kin...@gmail.com on 19 Feb 2013 at 3:39