search

etaty / rediscala

Non-blocking, Reactive Redis driver for Scala (with Sentinel support)
Apache License 2.0
790 stars 142 forks source link

Sentinel pool slave #103

Closed npeters closed 8 years ago

npeters commented 8 years ago

sentinel manage a slave pool:

etaty commented 8 years ago

:+1: Ping me when it is ready for review

npeters commented 8 years ago

today ?

etaty commented 8 years ago

Can you put the return for all the function even : Unit = {}

etaty commented 8 years ago

Hey, you are on the good path :smiley: ps: You need to be careful with the indentation (sometime there is too much tabs or not enough) (I will try to automate that #107)

etaty commented 8 years ago

In the tests there are a lot of Thread.sleep and println, could you try to clean that? For example, you could use within(1 second, 4 seconds), I use that in redis.actors test

npeters commented 8 years ago

I finally find a bug on mutable pool I try to simplify the design

etaty commented 8 years ago

thanks