Add multi sentinel support

etaty / rediscala

Non-blocking, Reactive Redis driver for Scala (with Sentinel support)

Apache License 2.0

790 stars 142 forks source link

Add multi sentinel support #11

Closed tovbinm closed 11 years ago

coveralls commented 11 years ago

Changes Unknown when pulling fe6db9cd3537db854c266d1fdc1d8df92676343c on tovbinm:mt/multi_sentinel into \ on etaty:master**.

etaty commented 11 years ago

Really great :)

I don't really know about the use cases of Sentinel. Maybe it would be nice to add and remove Sentinels when they spawn and die. So during the life of you Scala program you could start with a cluster of A machines and move to B machines.

tovbinm commented 11 years ago

Usually you run one sentinel process on each machine. For instance, if we have three Redis instances: one master and two slaves; then we'll have three sentinel processes, one per machine. Sentinels are not likely to die, except when the whole machine is down.

tovbinm commented 11 years ago

Oh, do you mean detecting new sentinels automatically? i.e. subscribing to "+sentinel " and "-dup-sentinel " ?

etaty commented 11 years ago

Yes, detecting new sentinels and starting a connection to it.

tovbinm commented 11 years ago

Then it probably should be done internally in SentinelClient.

etaty commented 11 years ago

Yes SentinelClient fire a callback, and the MonitoredClient can act on it (starting a new SentinelClient for example)

coveralls commented 11 years ago

Changes Unknown when pulling 731948a182601b28cc81618f1d6969cb4bb86067 on tovbinm:mt/multi_sentinel into \ on etaty:master**.

tovbinm commented 11 years ago

@etaty , added sentinels auto discovery

coveralls commented 11 years ago

Changes Unknown when pulling 5cdd8b4a848f349ee66a789edfe4c6e8e8ecf7f1 on tovbinm:mt/multi_sentinel into \ on etaty:master**.

etaty commented 11 years ago

looks good, i will merge it during the weekend. thanks :)

tovbinm commented 11 years ago

Great! Looking forward hearing from you.

etaty commented 11 years ago

Can you tell me if it's ready to be merged ?

tovbinm commented 11 years ago

Not yet. I'll ping you. ;)

-Matthew On Sep 16, 2013 12:38 AM, "Valerian" notifications@github.com wrote:

Can you tell me if it's ready to be merged ?

— Reply to this email directly or view it on GitHubhttps://github.com/etaty/rediscala/pull/11#issuecomment-24480891 .

tovbinm commented 11 years ago

@etaty what else should be done for this one?

etaty commented 11 years ago

Merging :) I will do it during this weekend

tovbinm commented 11 years ago

Awesome!

etaty commented 11 years ago

thanks :)

I will release version 1.3 during the week