search

etaty / rediscala

Non-blocking, Reactive Redis driver for Scala (with Sentinel support)
Apache License 2.0
790 stars 142 forks source link

Fixed SET command serialization #37

Closed th0br0 closed 10 years ago

th0br0 commented 10 years ago

If EX was set, SET would discard the NX flag. However, SET key value NX EX duration is a valid command.

etaty commented 10 years ago

Thanks :+1: Do you have few minutes to write a test, so the bug does not appear again ?

th0br0 commented 10 years ago

Sure, I'll do that. You're only testing for effects though and not requests right now, are you?

etaty commented 10 years ago

Yes. I was testing for effect (i think it is called integration test). Because Redis is fast, and the case are simple and limited. In your case, if you want, you can test only the generated byteString request, it will be ok.