search

etaty / rediscala

Non-blocking, Reactive Redis driver for Scala (with Sentinel support)
Apache License 2.0
790 stars 142 forks source link

Sub Message data type #63

Closed btd closed 9 years ago

btd commented 9 years ago

Hi.

I am trying to use RedisPubSub and noticed that Message case class have data String, which is strange (and encode it to utf8). It looks more sense will be if it will be ByteString because message is just bytes (and i cannot use now java serialization to decode case classes). Or maybe i miss something - how can i use data String to deserialize case class?

etaty commented 9 years ago

Yes you are right. If you want to do a PR, you have to remove the last utf8String calls for Message and PMessage https://github.com/etaty/rediscala/blob/1096f43870db6a314f7ea4f2a56952d5e817975a/src/main/scala/redis/actors/RedisSubscriberActor.scala#L93-L96

etaty commented 9 years ago

fix merged for version 1.5 Thanks