search

etaty / rediscala

Non-blocking, Reactive Redis driver for Scala (with Sentinel support)
Apache License 2.0
790 stars 142 forks source link

Adding HyperLogLog support with tests #88

Closed owynrichen closed 9 years ago

owynrichen commented 9 years ago

I have a need to estimate cardinality of a data set and redis HyperLogLog commands were just the ticket.

See: http://redis.io/commands#hyperloglog

Also, I noticed a few tests were failing on my local build, with Redis 2.8.21, so I tried to fix them so they worked with both 2.8.19 (the one Travis CI seems to use) and 2.8.21.

owynrichen commented 9 years ago

@etaty, I'm trying to reproduce the failure in the openjdk build locally in a vagrant host, which is triggering the failed check above, and I'm having a bit of a challenge. Is there a potential race condition in those cases?

etaty commented 9 years ago

Yeah it fails for some unknown reason (it's not linked to the oracle jdk or open jdk). Just ignore them, if it works on your local, it's ok for me.

owynrichen commented 9 years ago

Yeah, it definitely works in my local vagrant openjdk setup and also in the oraclejdk setup on my mac. Thanks!