search

etcd-io / auger

Directly access data objects stored in etcd by Kubernetes.
Apache License 2.0
48 stars 14 forks source link

failing build with make release #156

Open mathias-goebel opened 3 days ago

mathias-goebel commented 3 days ago 
> make release
[…]
go: downloading github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd
error obtaining VCS status: exit status 128
    Use -buildvcs=false to disable VCS stamping.
make: *** [/go/src/github.com/etcd-io/auger/Makefile:67: release-docker-build] Error 1
make: *** [Makefile:55: release] Error 2

but works as expected with -buildvcs=false added to Makefile line 67.

jmhbnz commented 1 day ago

/assign

jmhbnz commented 1 day ago

I believe the issue is the wrong docker image being used in the make release recipe. The following diff for Makefile I believe fixes it:

-               golang:$(GO_VERSION) \
-               /bin/bash -c "make -f /go/src/$(PKG)/Makefile release-docker-build GOARCH=$(GOARCH) GOOS=$(GOOS) CGO_ENABLED=$(CGO_ENABLED)"
+               docker.io/golang:$(GO_VERSION)-alpine \
+               sh -c "make -f /go/src/$(PKG)/Makefile release-docker-build GOARCH=$(GOARCH) GOOS=$(GOOS) CGO_ENABLED=$(CGO_ENABLED)"

Would you mind testing with this patch applied and confirming?

mathias-goebel commented 9 hours ago

sorry, there is no make in docker.io/golang:$(GO_VERSION)-alpine