Dedupe Reload/NoSyncReload, prefer empty instead of nil init

etcd-io / bbolt

An embedded key/value database for Go.

https://go.etcd.io/bbolt

MIT License

8.32k stars 645 forks source link

Dedupe Reload/NoSyncReload, prefer empty instead of nil init #804

Closed tjungblu closed 3 months ago

tjungblu commented 3 months ago

Reload and NoSyncReload have duplicated code, this unifies both for later refactoring.

This PR is split from #786, where the tests found differences on reloading and nil/empty initializations. Added some more clarifications in godocs for certain panic behavior and expected returns on the interface.

k8s-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/etcd-io/bbolt/blob/main/OWNERS)~~ [ahrtr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment