search

etcd-io / bbolt

An embedded key/value database for Go.
https://go.etcd.io/bbolt
MIT License
8.31k stars 646 forks source link

[1.3] backport failpoints(resizeFileError, lackOfDiskSpace) and dmflakey on XFS #816

Closed fuweid closed 3 months ago

fuweid commented 3 months ago

cherry-pick:

ahrtr commented 3 months ago

cc @tjungblu

tjungblu commented 3 months ago

/lgtm

thank you @fuweid

k8s-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ahrtr, fuweid

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/etcd-io/bbolt/blob/release-1.3/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ahrtr commented 3 months ago

@fuweid the robustness test failed right after merging this PR, can you take a look? thx https://github.com/etcd-io/bbolt/actions/runs/10316542012/job/28558983342

cc @tjungblu

fuweid commented 3 months ago

@fuweid the robustness test failed right after merging this PR, can you take a look? thx https://github.com/etcd-io/bbolt/actions/runs/10316542012/job/28558983342

cc @tjungblu

=== RUN TestRestartFromPowerFailureExt4/fp_ext4_commit1s powerfailure_test.go:168: start bbolt bench -work -path /tmp/TestRestartFromPowerFailureExt4fp_ext4_commit1s370634247/002/boltdb -count=1000000000 -batch-size=5 powerfailure_test.go:185: simulate power failure powerfailure_test.go:190: random pick failpoint: mapError powerfailure_test.go:199: bbolt should stop with panic in seconds

The bbolt command wasn't panic in 10 seconds.

fuweid commented 3 months ago

I need to backport this one as well

https://github.com/etcd-io/bbolt/commit/49eb212fa8ab67709ea460df01982504cf7fa4a1