search

etcd-io / bbolt

An embedded key/value database for Go.
https://go.etcd.io/bbolt
MIT License
8.32k stars 645 forks source link

[1.3] Bump go version to 1.22.8 #837

Closed PyAgni closed 1 month ago

PyAgni commented 1 month ago

https://github.com/etcd-io/etcd/issues/18665

ivanvc commented 1 month ago

Quick question, @ahrtr: did you manually approve the workflows for the pull request? I see it skipped the ok-to-test label, but I'm unsure why the tests ran.

ahrtr commented 1 month ago

Quick question, @ahrtr: did you manually approve the workflows for the pull request?

Yes, maintainers need to manually trigger workflow for first-time contributors. Please feel free to introduce ok-to-test mechanism to bbolt if you have time. thx

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ahrtr, ivanvc, PyAgni

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/etcd-io/bbolt/blob/release-1.3/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ivanvc commented 1 month ago

Yes, maintainers need to manually trigger workflow for first-time contributors. Please feel free to introduce ok-to-test mechanism to bbolt if you have time. thx

I forgot to follow up on this comment. We have it in place (https://github.com/etcd-io/bbolt/pull/638), but I'm not sure why every new PR in the etcd repo has the needs-ok-to-test and not here.

ahrtr commented 1 month ago

I forgot to follow up on this comment. We have it in place (#638), but I'm not sure why every new PR in the etcd repo has the needs-ok-to-test and not here.

It seems that you did not get release-1.3 included in the list?

https://github.com/etcd-io/bbolt/blob/12280e06d5de2160374dafde6dbc194a1e7db9a3/.github/workflows/gh-workflow-approve.yaml#L9-L10

ivanvc commented 1 month ago

It seems that you did not get release-1.3 included in the list?

Good catch. I'll open a PR and move the conversation there.