search

etcd-io / bbolt

An embedded key/value database for Go.
https://go.etcd.io/bbolt
MIT License
8.31k stars 646 forks source link

github/workflows: remove arm64 jobs #844

Closed ivanvc closed 3 weeks ago

ivanvc commented 1 month ago

Remove the ARM64 jobs from GitHub workflows. Add a comment regarding the use of sudo in robustness tests.

Link to #848

k8s-ci-robot commented 1 month ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

ivanvc commented 1 month ago

/test all

ivanvc commented 1 month ago

/retest

ivanvc commented 1 month ago

/test pull-bbolt-robustness-arm64

ivanvc commented 1 month ago

/test pull-bbolt-robustness-arm64

k8s-ci-robot commented 1 month ago

@ivanvc: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-bbolt-robustness-arm64 1d7a65f59fc5399f49b86247a2b6a510e5a6de34 link true /test pull-bbolt-robustness-arm64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
ivanvc commented 1 month ago

@jmhbnz and I have been discussing the migration of robustness tests. The current issue is that we can't install xfsprogs in the container/prow job pod (https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/etcd-io_bbolt/844/pull-bbolt-robustness-arm64/1849591798716960768#). The reason is highly likely that the host node doesn't have the XFS filesystem. Therefore, we can't use dm-flakey.

As we will need help from the infra team, James suggests reaching out to k/test-infra and #sig-k8s-infra, which I'll do shortly.

ivanvc commented 3 weeks ago

@ahrtr, do you know (or provide some guidance on) why the 4 CPU tests with race are getting stuck? I could add a timeout, but that would make the job fail. I'm running them in Prow using the same command we used in the GitHub workflow.

Refer to https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/etcd-io_bbolt/846/pull-bbolt-test-4-cpu-race-arm64/1851126914400391168

ahrtr commented 3 weeks ago

do you know (or provide some guidance on) why the 4 CPU tests with race are getting stuck?

It looks like the test infra's issue, the test process somehow terminated or being blocked. 1000 concurrent goroutines shouldn't cause too much resource pressure. Not sure whether we can request some help from test-infra, probably they have more insight.

=== RUN TestSimulateNoFreeListSync_10000op_1000p btesting.go:47: Opening bbolt DB at: /tmp/TestSimulateNoFreeListSync_10000op_1000p788848248/001/db

ivanvc commented 3 weeks ago

/help test

ivanvc commented 3 weeks ago

I'll mark this PR ready for review to check the triggered prow jobs.

ivanvc commented 3 weeks ago

@ahrtr, other than the comment on the TODO. The prow jobs triggered look fine, and they are all green.

k8s-ci-robot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/etcd-io/bbolt/blob/main/OWNERS)~~ [ahrtr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment