search

etcd-io / bbolt

An embedded key/value database for Go.
https://go.etcd.io/bbolt
MIT License
8.31k stars 646 forks source link

Add changelog for 1.4.0-beta.0 #847

Closed ahrtr closed 2 weeks ago

ahrtr commented 3 weeks ago

Link to https://github.com/etcd-io/bbolt/issues/553

ivanvc commented 3 weeks ago

Sorry about the robustness failure. It's due to a prow infra current limitation, I'm aware and tracking it.

Should we add a note regarding Go 1.23.2? I see that previous releases did mention the Go version used (#836).

k8s-ci-robot commented 3 weeks ago

@ahrtr: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-bbolt-robustness-arm64 2709ffc4c01fb831ec7e5c8c2bb42216a56680ca link false /test pull-bbolt-robustness-arm64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
ahrtr commented 3 weeks ago

Should we add a note regarding Go 1.23.2? I see that previous releases did mention the Go version used (#836).

Thanks for the reminder. Updated the changelog to only mention that it requires 1.23.x. bbolt is used as a library, it's up to users/application to decide the exact go version. We just need to clear call out the minor go version.

It's due to a prow infra current limitation, I'm aware and tracking it.

Thanks. If it needs a long time to resolve the issue (i.e. > 2 months), can we add it back to github for now (without arm64)?

ivanvc commented 3 weeks ago

Thanks. If it needs a long time to resolve the issue (i.e. > 2 months), can we add it back to github for now (without arm64)?

PTAL at kubernetes/test-infra#33735. I say let's hold them to avoid the noise. Restoring them should be quick.

k8s-ci-robot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/etcd-io/bbolt/blob/main/OWNERS)~~ [ahrtr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ahrtr commented 3 weeks ago

cc @fuweid @jmhbnz @serathius @tjungblu for awareness