search

etcd-io / bbolt

An embedded key/value database for Go.
https://go.etcd.io/bbolt
MIT License
8.31k stars 646 forks source link

Bump go toolchain to 1.23.3 #856

Closed samuelbartels20 closed 1 week ago

samuelbartels20 commented 2 weeks ago

…uel20@gmail.com> Please review

k8s-ci-robot commented 2 weeks ago

Hi @samuelbartels20. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
henrybear327 commented 2 weeks ago

@samuelbartels20 please update the PR title :) Thanks!

samuelbartels20 commented 2 weeks ago

@samuelbartels20 please update the PR title :) Thanks!

@henrybear327 Please i don't understand. Could you please elaborate what you mean?

ivanvc commented 2 weeks ago

/ok-to-test /retitle Bump go toolchain to 1.23.3

ivanvc commented 2 weeks ago

Link to https://github.com/etcd-io/etcd/issues/18847

henrybear327 commented 2 weeks ago

@samuelbartels20 please update the PR title :) Thanks!

@henrybear327 Please i don't understand. Could you please elaborate what you mean?

Sorry that I just saw your message.

It's done by @ivanvc already!

k8s-ci-robot commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc, samuelbartels20

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/etcd-io/bbolt/blob/main/OWNERS)~~ [ahrtr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment