etcd-io / etcd

Distributed reliable key-value store for the most critical data of a distributed system
https://etcd.io
Apache License 2.0
47.79k stars 9.77k forks source link

Support triggering multiple failpoints at once #14728

Open serathius opened 1 year ago

serathius commented 1 year ago

What would you like to be added?

This is limitation of https://github.com/etcd-io/gofail library we use in linearizability and functional testing. In command line interface user can provide multiple failpoints, but when using HTTP endpoint we can only provide one failpoint at once https://github.com/etcd-io/gofail#http-endpoint.

Why is this needed?

This would allow better reproduction of more complicated issues. Some reproduction requires coordinating multiple independent processes within etcd. For example we could inject sleep in one routine and panic in other.

ahrtr commented 1 year ago

This might need to be resolved in gofail instead of etcd. Let me take a look.

serathius commented 1 year ago

This might need to be resolved in gofail instead of etcd. Let me take a look.

This issue will need to introduce changes on bolt, however let's track integration to etcd.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.