search

etcd-io / etcd

Distributed reliable key-value store for the most critical data of a distributed system
https://etcd.io
Apache License 2.0
47.73k stars 9.76k forks source link

Image with 'latest' tag corresponds to an older etcd version #15382

Open nickbel7 opened 1 year ago

nickbel7 commented 1 year ago

What happened?

I tried to deploy an etcd cluster as a StatefulSet using the etcd image from the quay.io/coreos/etcd repository, using the 'latest' tag, as proposed in the following documentation (https://etcd.io/docs/v2.3/docker_guide/). The etcd version that I get in each pod is the v3.3.8 (neither 3.4 or 3.5) which is a older version of etcd.

Is this something that has been done on purpose because of the parallel maintenance of the 3.4 and 3.5 versions ? If so, I would expect that the default etcd documentation does not prompt to use the latest tag (or state that this is not a good practice).

What did you expect to happen?

I would expect that the newly created etcd pods would have the version tagged as 'latest' in the github releases page (https://github.com/etcd-io/etcd/releases).

How can we reproduce it (as minimally and precisely as possible)?

(Fast way) Docker

Anything else we need to know?

No response

Etcd version (please run commands below)

```console $ etcd --version etcd Version: 3.3.8 Git SHA: 33245c6b5 Go Version: go1.9.7 Go OS/Arch: linux/amd64 $ etcdctl version etcdctl version: 3.3.8 API version: 2 ```

Etcd configuration (command line flags or environment variables)

# paste your configuration here

Etcd debug information (please run commands below, feel free to obfuscate the IP address or FQDN in the output)

```console $ etcdctl member list -w table # paste output here $ etcdctl --endpoints= endpoint status -w table # paste output here ```

Relevant log output

$ kubectl exec -it etcd-0 -- etcd --version
etcd Version: 3.3.8
serathius commented 1 year ago

Looks like it's a repeat of https://github.com/etcd-io/etcd/issues/13606 but for quey repo.

tjungblu commented 1 year ago

I'd be also +1 to just remove the latest tag, it's generally misused and clearly still pointing to some ancient release created 6 years ago. Do you guys still have access to the coreos quay repo? Otherwise I can go and find some people that can clean the tags up internally.

If so, I would expect that the default etcd documentation does not prompt to use the latest tag (or state that this is not a good practice).

@nickbel7 you're browsing the documentation from etcd 2.3. Not sure we need to go and amend older release docs, the message at the top seems pretty clear to me.

nickbel7 commented 1 year ago

you're browsing the documentation from etcd 2.3

@tjungblu You are right, I was aware of that. However, I didn't find the same page in earlier versions of the documentation. In v3.5 for example, I noticed the installation process regarding Kubernetes is incomplete (https://etcd.io/docs/v3.5/install/). As I understand, someone would have to go to the github releases page in order to see that gcr.io/etcd-development/etcd is the primary container registry

ahrtr commented 1 year ago

you're browsing the documentation from etcd 2.3

@tjungblu You are right, I was aware of that. However, I didn't find the same page in earlier versions of the documentation. In v3.5 for example, I noticed the installation process regarding Kubernetes is incomplete (https://etcd.io/docs/v3.5/install/). As I understand, someone would have to go to the github releases page in order to see that gcr.io/etcd-development/etcd is the primary container registry

There is a feature request to address this. https://github.com/etcd-io/etcd/issues/15185 It looks like we can update the guide https://etcd.io/docs/v3.5/install/.

jmhbnz commented 1 year ago

Hey @ahrtr, @serathius do we have permissions to be able to remove latest from quay.io?

There was a comment on https://github.com/etcd-io/etcd/issues/13606, users are still running into confusion in relation to latest. My vote would also go to just removing it so we can close out this issue and hopefully prevent some confusion.

serathius commented 6 months ago

Hey @ahrtr, @serathius do we have permissions to be able to remove latest from quay.io?

Yes, feel free to remove it.