etcd-io / etcd

Distributed reliable key-value store for the most critical data of a distributed system
https://etcd.io
Apache License 2.0
47.66k stars 9.75k forks source link

Add a top level OWNERS file to top each etcd.io subproject #16367

Closed wenjiaswe closed 2 months ago

wenjiaswe commented 1 year ago

What would you like to be added?

Add a top level OWNERS file to top each etcd.io subproject.

Why is this needed?

It's a hard requirement to set up sig-etcd: https://github.com/kubernetes/community/pull/7372#discussion_r1282462443.

jmhbnz commented 1 year ago

Here is our list of all repos for reference:

Archive - Don't add OWNERS:

OWNERS file completed

jmhbnz commented 1 year ago

Hey Team - I've confirmed with @mrbobbytables that repositories marked as public archive do not need to be included in this work of seeding initial OWNERS files.

With that in mind I would like to propose @etcd-io/maintainers-etcd mark the etcd-io/maintainers, etcd-io/zetcd and etcd-io/cetd repositories as public archive as they are no longer maintained.

Based on my list above that would then leave us 12 pr's to raise. I have made a start on the first one to get us moving: https://github.com/etcd-io/etcd/pull/16600

jmhbnz commented 1 year ago

Update: All required OWNERS files have now been merged. There were four repositories proposed for public archival, 3/4 have been completed, the other one is in progress pending maintainer majority approval.

We have an active pr in progress on the kubernetes/org repo to implement automated management for the etcd-io org: https://github.com/kubernetes/org/pull/4498.

Once that is merged we should cleanup to ensure: 1 - Any process documentation about repository access management is updated 2 - Remove the now defunct / duplicate MAINTAINERS files.

The following repositories will need a cleanup pr to at minimum remove old MAINTAINERS file:

jmhbnz commented 11 months ago

All etcd-io subprojects now have a top level OWNERS file where required and followup action to tidy up old MAINTAINERS files has also been completed, closing.

As a next step we should begin exploring more fine grained code ownership for specific aspects of etcd-io/etcd but that can be addressed in subsequent issues.

jmhbnz commented 3 months ago

Reopen to backport OWNERS to release-3.5 and release-3.4 in support of improved automation via prow.

jmhbnz commented 2 months ago

Discussed during sig-etcd triage meeting, assigned to @thedtripp for backport https://github.com/etcd-io/etcd/pull/16794 to release-3.5 and release-3.4.

/assign @thedtripp

k8s-ci-robot commented 2 months ago

@jmhbnz: GitHub didn't allow me to assign the following users: thedtripp.

Note that only etcd-io members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to [this](https://github.com/etcd-io/etcd/issues/16367#issuecomment-2263712745): >Discussed during sig-etcd triage meeting, assigned to @thedtripp for backport https://github.com/etcd-io/etcd/pull/16794 to `release-3.5` and `release-3.4`. > >/assign @thedtripp Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
thedtripp commented 2 months ago

/assign @thedtripp

k8s-ci-robot commented 2 months ago

@thedtripp: GitHub didn't allow me to assign the following users: thrdtripp.

Note that only etcd-io members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to [this](https://github.com/etcd-io/etcd/issues/16367#issuecomment-2263751459): >/assign @thrdtripp Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
thedtripp commented 2 months ago

/assign @thedtripp

jmhbnz commented 2 months ago

Hey @thedtripp - Now that we have release-3.5 completed do you have capacity to also tackle the backport release-3.4 so we can close this out? 🙏🏻

thedtripp commented 2 months ago

Hey @jmhbnz, yes, I will work on this over the next few days.

jmhbnz commented 2 months ago

Backports completed - closing 🎉