search

etcd-io / etcd

Distributed reliable key-value store for the most critical data of a distributed system
https://etcd.io
Apache License 2.0
47.68k stars 9.76k forks source link

Backport https://github.com/etcd-io/etcd/pull/12896 to 3.4.x #17712

Open bsdnet opened 6 months ago

bsdnet commented 6 months ago

What would you like to be added?

We carried the patch https://github.com/etcd-io/etcd/pull/12896 internally for years. The patch really improves the stability and performance in our fleet.

We believed this patch should also be benefitial to other vendors who uses 3.4.x.

Would OSS consider this request?

Thank you

Why is this needed?

The patch was well tested in our fleet and improves the performance and stability. Backporting will benefit all stakeholders who are using 3.4.x

siyuanfoundation commented 6 months ago

Thank you @bsdnet for raising this issue. Can you run a heatmap benchmark for 3.4 with and without the patch, similar to https://github.com/etcd-io/etcd/pull/12896#issuecomment-829585476? Thanks!

bsdnet commented 6 months ago

Can you run a heatmap benchmark for 3.4 with and without the patch, similar to https://github.com/etcd-io/etcd/pull/12896#issuecomment-829585476? Thanks!

Do we have any instructions for new etcd users?

When we backported the patch, the developer had done the tests. The patch was applied to our fleet for years.

siyuanfoundation commented 6 months ago

This is the instructions of how to use the heatmap benchmark https://github.com/etcd-io/etcd/tree/main/tools/rw-heatmaps

bsdnet commented 5 months ago

@Random-Liu, @jinxu97 FYI