Open jcferretti opened 3 months ago
Hi @jcferretti. Thanks for your PR.
I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
Hi @jcferretti, thanks for your contribution. Could you please sign your commit? So the developer certificate of origin (DCO) check passes, i.e:
git rebase HEAD~1 --signoff
git push --force
Thanks!
Ref: https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#commit-your-change
Hi @jcferretti, thanks for your contribution. Could you please sign your commit? So the developer certificate of origin (DCO) check passes, i.e:
git rebase HEAD~1 --signoff git push --force
Thanks!
Ref: https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#commit-your-change
Done, thank you, sorry about missing that.
Please add a test to reproduce the issue which you are trying to fix firstly.
Please add a test to reproduce the issue which you are trying to fix firstly.
Can you please comment on the issue report regarding the analysis there? Thanks. https://github.com/etcd-io/etcd/issues/18163
Fixes #18163