etcd-io / etcd

Distributed reliable key-value store for the most critical data of a distributed system
https://etcd.io
Apache License 2.0
47.5k stars 9.74k forks source link

Fix govulncheck CI check on release-3.4 #18172

Closed henrybear327 closed 3 months ago

henrybear327 commented 3 months ago

This commit fixed the Go Vulnerability Checker CI job, which isn't scanning for all go.mod files within the project.

Reference:

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

henrybear327 commented 3 months ago

/retest

henrybear327 commented 3 months ago

/retest

ahrtr commented 3 months ago

3.4 has only one go module.

ivanvc commented 3 months ago

3.4 has only one go module.

Good point. We don't need this change then.

henrybear327 commented 3 months ago

My idea was that we update it in case we need this in the future, but after a second thought, we would never do active development here anymore, so I will close this one for now!

Thanks @ahrtr and @ivanvc for the quick help!