search

etcd-io / etcd

Distributed reliable key-value store for the most critical data of a distributed system
https://etcd.io
Apache License 2.0
47.5k stars 9.74k forks source link

[3.5] bugfix: register of walWriteSec #18174

Closed andyxning closed 3 months ago

andyxning commented 3 months ago

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

cherry-pick https://github.com/etcd-io/etcd/pull/18164 to release-3.5

/cc @ivanvc

k8s-ci-robot commented 3 months ago

Hi @andyxning. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
ivanvc commented 3 months ago

/ok-to-test

andyxning commented 3 months ago

@ivanvc This is a bugfix to adding support for walWriteSec and walWriteSec was added in v3.5. There is no need to update in the changelog, imho.

ivanvc commented 3 months ago

@ivanvc This is a bugfix to adding support for walWriteSec and walWriteSec was added in v3.5. There is no need to update in the changelog, imho.

Yes, but at least 3.5.14 was released with this bug. I think that's why we need the release note, and why Benjamin requested it.

ivanvc commented 3 months ago

/retitle [3.5] bugfix: register of walWriteSec