search

etcd-io / etcd

Distributed reliable key-value store for the most critical data of a distributed system
https://etcd.io
Apache License 2.0
47.5k stars 9.74k forks source link

Add run-govulncheck Makefile target #18182

Closed ivanvc closed 3 months ago

ivanvc commented 3 months ago

Add a Makefile target to run govuln across the submodules. This will allow it to be imported into a prow job and remove the logic from the GitHub workflow file.

Part of #18173.

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 68.57143% with 11 lines in your changes missing coverage. Please review.

Project coverage is 68.88%. Comparing base (45f1453) to head (2cee493). Report is 8 commits behind head on main.

:exclamation: Current head 2cee493 differs from pull request most recent head 0430960

Please upload reports for the commit 0430960 to get more accurate results.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files | [Files](https://app.codecov.io/gh/etcd-io/etcd/pull/18182?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [server/storage/mvcc/revision.go](https://app.codecov.io/gh/etcd-io/etcd/pull/18182?src=pr&el=tree&filepath=server%2Fstorage%2Fmvcc%2Frevision.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2VydmVyL3N0b3JhZ2UvbXZjYy9yZXZpc2lvbi5nbw==) | `91.48% <80.00%> (-3.39%)` | :arrow_down: | | [etcdutl/snapshot/v3\_snapshot.go](https://app.codecov.io/gh/etcd-io/etcd/pull/18182?src=pr&el=tree&filepath=etcdutl%2Fsnapshot%2Fv3_snapshot.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZXRjZHV0bC9zbmFwc2hvdC92M19zbmFwc2hvdC5nbw==) | `57.43% <64.00%> (+8.53%)` | :arrow_up: | ... and [21 files with indirect coverage changes](https://app.codecov.io/gh/etcd-io/etcd/pull/18182/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) ```diff @@ Coverage Diff @@ ## main #18182 +/- ## ========================================== + Coverage 68.82% 68.88% +0.06% ========================================== Files 416 416 Lines 35128 35151 +23 ========================================== + Hits 24177 24215 +38 + Misses 9549 9530 -19 - Partials 1402 1406 +4 ``` ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/etcd-io/etcd/pull/18182?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/etcd-io/etcd/pull/18182?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Last update [45f1453...0430960](https://app.codecov.io/gh/etcd-io/etcd/pull/18182?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None).
ivanvc commented 3 months ago

/retest

ivanvc commented 3 months ago

/retest

ivanvc commented 3 months ago

/retest

ivanvc commented 3 months ago

It seems like Robustness tests are consistently failing on the prow infra :face_with_head_bandage: https://prow.k8s.io/job-history/gs/kubernetes-jenkins/pr-logs/directory/pull-etcd-robustness-amd64

jmhbnz commented 3 months ago

It seems like Robustness tests are consistently failing on the prow infra 🤕 https://prow.k8s.io/job-history/gs/kubernetes-jenkins/pr-logs/directory/pull-etcd-robustness-amd64

Issue appears to be permissions for accessing the fuse device required for lazyfs robustness scenarios. I'll raise a pr to fix.

Edit: Opened https://github.com/kubernetes/test-infra/pull/32769

jmhbnz commented 3 months ago

/retest