Closed gyuho closed 1 week ago
Hi @gyuho. Thanks for your PR.
I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
Attention: Patch coverage is 46.15385%
with 7 lines
in your changes missing coverage. Please review.
Project coverage is 68.86%. Comparing base (
debc8fb
) to head (0734121
).:exclamation: Current head 0734121 differs from pull request most recent head 22f20a8
Please upload reports for the commit 22f20a8 to get more accurate results.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
/retest
@gyuho: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test
message.
/ok-to-test
/retest
cc @ahrtr
/retest
/retest
/retest
Otherwise, it will fail with
We should instead explicitly fail fast, with a clear error message.
Also, adding some documentation how to configure TLS for metrics URLs.
c.f., https://github.com/etcd-io/etcd/issues/8060