search

etcd-io / etcd

Distributed reliable key-value store for the most critical data of a distributed system
https://etcd.io
Apache License 2.0
46.77k stars 9.64k forks source link

tests/robustness: fix access of ChoiceWeight #18202

Closed MadhavJivrajani closed 1 week ago

MadhavJivrajani commented 1 week ago

Not sure what went wrong here... The CI for https://github.com/etcd-io/etcd/pull/18181 should have failed or marked a conflict?

Noticed failures first in: https://github.com/etcd-io/etcd/pull/18201

/assign @serathius

serathius commented 1 week ago

We don't have a merge queue like in K8s, so we don't test merging PRs together.

MadhavJivrajani commented 1 week ago

Makes sense @serathius, thanks. Can we merge this?

serathius commented 1 week ago

@MadhavJivrajani Yes, after the tests pass :P

MadhavJivrajani commented 1 week ago

Oh LOL yeah, my bad 🙈

serathius commented 1 week ago

/retest