search

etcd-io / etcd

Distributed reliable key-value store for the most critical data of a distributed system
https://etcd.io
Apache License 2.0
46.77k stars 9.64k forks source link

fix typo in mvcc: store.go #18209

Closed Willhow-Gao closed 1 week ago

Willhow-Gao commented 1 week ago

fix typo in mvcc module,store.go

k8s-ci-robot commented 1 week ago

Hi @Willhow-Gao. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
henrybear327 commented 1 week ago

/ok-to-test

Willhow-Gao commented 1 week ago

I think an even better fix, would be to remove the named return values, as they're not used in the implementation.

thx for your advice,already removed

ivanvc commented 1 week ago

@Willhow-Gao, can you squash your commits into a single one, and sign your commits so the developer certificate of origin (DCO) check passes?

You can squash your three commits and sign off by running:

git reset --soft HEAD~3
git commit --signoff -m <commit message>