Closed ahrtr closed 4 days ago
should we consider returning error early to also avoid setting empty endpoints?
I tend to keep it as it's. As long as MemberList
returns successfully, the endpoints should never be empty. Returning an error means that we need to add test to test/verify it, but we can't think of a single case to trigger this scenario.
It should be helpful to detect issue like https://github.com/etcd-io/etcd/issues/18090
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.