search

etcd-io / etcd

Distributed reliable key-value store for the most critical data of a distributed system
https://etcd.io
Apache License 2.0
46.77k stars 9.64k forks source link

etcdctl: add support for filtering by {min,max} x {create,mod} x {revision} #18233

Open jcferretti opened 3 days ago

jcferretti commented 3 days ago

etcdctl is missing options to modify get opts for WithMinCreateRev, WithMaxCreateRev, WithMinModRev, WithMaxModRev.

k8s-ci-robot commented 3 days ago

Hi @jcferretti. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
henrybear327 commented 1 day ago

/ok-to-test

@jcferretti please remember to sign-off your commits! Thanks!

jcferretti commented 1 day ago

/retest