search

etcd-io / etcd

Distributed reliable key-value store for the most critical data of a distributed system
https://etcd.io
Apache License 2.0
46.77k stars 9.64k forks source link

Add "feature-gates" flag and field in config file and add feature gate for StopGRPCServiceOnDefrag #18234

Open siyuanfoundation opened 3 days ago

siyuanfoundation commented 3 days ago

part of https://github.com/etcd-io/etcd/issues/18023

This PR includes changes to

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

siyuanfoundation commented 3 days ago

/cc @stackbaek @henrybear327

k8s-ci-robot commented 3 days ago

@siyuanfoundation: GitHub didn't allow me to request PR reviews from the following users: stackbaek.

Note that only etcd-io members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/etcd-io/etcd/pull/18234#issuecomment-2190327263): >/cc @stackbaek @henrybear327 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
serathius commented 23 hours ago

High level looks good, left some nits. cc @ahrtr

jmhbnz commented 12 hours ago

/retest