search

etcd-io / etcd

Distributed reliable key-value store for the most critical data of a distributed system
https://etcd.io
Apache License 2.0
47.36k stars 9.72k forks source link

Revision auto compaction should have configurable timer instead of fixed 5 minute timer #18471

Open jrcichra opened 3 weeks ago

jrcichra commented 3 weeks ago

What would you like to be added?

Today the revision auto compaction has a constant 5 minute compaction. Change this to be a command-line / environment variable configurable option.

Why is this needed?

With enough key revisions per second, the constant 5 minute interval on revision compaction isn't fast enough to keep up with growth. Consider making the interval configurable, which will override the default behavior of 5 minutes.

parthlaw commented 3 weeks ago

I would like to work on this issue.

jrcichra commented 3 weeks ago

I would like to work on this issue.

Hey @parthlaw , I have an implementation here I made along with the issue: https://github.com/etcd-io/etcd/pull/18472. Let me know what you think!

parthlaw commented 3 weeks ago

Thanks for the update @jrcichra . I am looking into the implementation. This is a great learning opportunity for me—Thanks for the guidance!

ivanvc commented 2 weeks ago

Discussed during the fortnightly triage meeting. @moficodes to review.