search

etcd-io / etcd

Distributed reliable key-value store for the most critical data of a distributed system
https://etcd.io
Apache License 2.0
47.86k stars 9.77k forks source link

etcdserver: creates a non-empty raft log snapshot on server startup #18494

Closed clement2026 closed 1 month ago

clement2026 commented 2 months ago

18459 requires that a non-empty raft log snapshot is always available. This PR creates a non-empty raft log snapshot on server startup.

Part of https://github.com/etcd-io/etcd/issues/17098

Key changes

Blocked by

k8s-ci-robot commented 2 months ago

Hi @clement2026. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
codecov-commenter commented 2 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 22.50000% with 31 lines in your changes missing coverage. Please review.

Project coverage is 68.79%. Comparing base (2c53be7) to head (8ab968e). Report is 14 commits behind head on main.

:exclamation: Current head 8ab968e differs from pull request most recent head ccbec07

Please upload reports for the commit ccbec07 to get more accurate results.

Files with missing lines Patch % Lines
client/v3/kubernetes/client.go 0.00% 27 Missing :warning:
server/etcdserver/server.go 69.23% 3 Missing and 1 partial :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files | [Files with missing lines](https://app.codecov.io/gh/etcd-io/etcd/pull/18494?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [server/etcdserver/server.go](https://app.codecov.io/gh/etcd-io/etcd/pull/18494?src=pr&el=tree&filepath=server%2Fetcdserver%2Fserver.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2VydmVyL2V0Y2RzZXJ2ZXIvc2VydmVyLmdv) | `81.13% <69.23%> (-0.14%)` | :arrow_down: | | [client/v3/kubernetes/client.go](https://app.codecov.io/gh/etcd-io/etcd/pull/18494?src=pr&el=tree&filepath=client%2Fv3%2Fkubernetes%2Fclient.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Y2xpZW50L3YzL2t1YmVybmV0ZXMvY2xpZW50Lmdv) | `0.00% <0.00%> (ø)` | | ... and [22 files with indirect coverage changes](https://app.codecov.io/gh/etcd-io/etcd/pull/18494/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) ```diff @@ Coverage Diff @@ ## main #18494 +/- ## ======================================= Coverage 68.79% 68.79% ======================================= Files 420 420 Lines 35489 35471 -18 ======================================= - Hits 24413 24404 -9 + Misses 9646 9633 -13 - Partials 1430 1434 +4 ``` ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/etcd-io/etcd/pull/18494?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/etcd-io/etcd/pull/18494?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Last update [2c53be7...ccbec07](https://app.codecov.io/gh/etcd-io/etcd/pull/18494?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None).
k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: clement2026 Once this PR has been reviewed and has the lgtm label, please assign ahrtr for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/etcd-io/etcd/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 2 months ago

@clement2026: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/etcd-io/etcd/pull/18494#issuecomment-2323029071): >/retest Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
ivanvc commented 2 months ago

/ok-to-test

clement2026 commented 2 months ago

Hey @serathius, it would be great if you could check this out when you have a moment. Thanks!

ahrtr commented 2 months ago

18459 requires that a non-empty raft log snapshot is always available.

Can you explain this? Why a non-empty snapshot is always required? We don't have such restriction before.

clement2026 commented 2 months ago

Can you explain this? Why a non-empty snapshot is always required? We don't have such restriction before.

@ahrtr sure, check out this comment for more details https://github.com/etcd-io/etcd/pull/18459#issuecomment-2295388421

k8s-ci-robot commented 1 month ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
clement2026 commented 1 month ago

After chatting with serathius, I've realized this PR isn’t needed anymore. I'll keep working on https://github.com/etcd-io/etcd/issues/17098 in a new PR. Closing this.