Closed henrybear327 closed 1 month ago
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Attention: Patch coverage is 0%
with 27 lines
in your changes missing coverage. Please review.
Project coverage is 68.85%. Comparing base (
fe796ab
) to head (d82b977
). Report is 2 commits behind head on main.:exclamation: Current head d82b977 differs from pull request most recent head 06a6da0
Please upload reports for the commit 06a6da0 to get more accurate results.
Files with missing lines | Patch % | Lines |
---|---|---|
client/v3/kubernetes/client.go | 0.00% | 27 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@henrybear327, it looks like dependabot didn't try to update go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc
to 1.29.0. I think it's because we closed #18297, as it looked indirect, but it's a direct dependency defined in server/go.mod
. So, maybe along with your commit 7ef38ee, you can update that dependency too if that makes sense.
I think it's because we closed #18297, as it looked indirect, but it's a direct dependency defined in
server/go.mod
Right. purely indirect
should mean that it's a purely indirect dependency in all modules.
maybe along with your commit 7ef38ee, you can update that dependency too
+1
So, maybe along with your commit 7ef38ee, you can update that dependency too if that makes sense.
It's OK to address it in a separate PR, which might be a little easier. @henrybear327 Please let's know if you want to resolve it in this PR or a separate PR
➜ etcd git:(dependencies/08_29_24) grep -Ri "go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v" | grep -v sum
./etcdutl/go.mod: go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.27.0 // indirect
./go.mod: go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.27.0 // indirect
./tests/go.mod: go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.27.0 // indirect
./server/go.mod: go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.27.0
I can bump it now. Sorry for missing the discussion!
LGTM. As @ahrtr suggested, we can bump
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc
in a follow-up pull request. Thanks, Henry.
@ivanvc @ahrtr bumped the dependency as requested/spotted!
Sorry for missing out on the previous comment again.
/retest
/retest
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ahrtr, henrybear327, ivanvc
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
This pull request completes this week's etcd dependency updates following our dependency roster and dependency management instructions.
Summary of actions
Bumped
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.