etcd-io / etcd

Distributed reliable key-value store for the most critical data of a distributed system
https://etcd.io
Apache License 2.0
47.72k stars 9.76k forks source link

Add revision to reads in TXN to robustness test and add regression test #18683

Open serathius opened 3 weeks ago

serathius commented 3 weeks ago

What would you like to be added?

Issue https://github.com/etcd-io/etcd/issues/18667 was not detected by robustness test because TXN we generate don't set revision in range. We should fix this gap.

TODO:

Note, until fix for https://github.com/etcd-io/etcd/issues/18667 is merged, we cannot enable running this test by default. Might need to make setting revision optional and only run it as regression test, only later enabling it by default.

As discussed on Slack @henrybear327 volunteered to work on it.

Why is this needed?

Cover detect and prevent https://github.com/etcd-io/etcd/issues/18667

serathius commented 6 days ago

Any progress?

serathius commented 4 days ago

ping @henrybear327