etcd-io / etcd

Distributed reliable key-value store for the most critical data of a distributed system
https://etcd.io
Apache License 2.0
47.89k stars 9.78k forks source link

[2024-11-04] Manual Dependency Bump #18840

Closed ArkaSaha30 closed 2 weeks ago

ArkaSaha30 commented 2 weeks ago

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

This pull request completes this week's etcd dependency updates following our dependency roster and dependency management instructions.

Dependabot raised the following PRs:

Bumped:

Purely Indirect:

codecov-commenter commented 2 weeks ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.92%. Comparing base (bd88963) to head (f120947). Report is 4 commits behind head on main.

:exclamation: Current head f120947 differs from pull request most recent head 8c60762

Please upload reports for the commit 8c60762 to get more accurate results.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files [see 19 files with indirect coverage changes](https://app.codecov.io/gh/etcd-io/etcd/pull/18840/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) ```diff @@ Coverage Diff @@ ## main #18840 +/- ## ========================================== + Coverage 68.78% 68.92% +0.13% ========================================== Files 420 420 Lines 35523 35522 -1 ========================================== + Hits 24433 24482 +49 + Misses 9665 9621 -44 + Partials 1425 1419 -6 ``` ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/etcd-io/etcd/pull/18840?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/etcd-io/etcd/pull/18840?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Last update [bd88963...8c60762](https://app.codecov.io/gh/etcd-io/etcd/pull/18840?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None).
ArkaSaha30 commented 2 weeks ago

/retest pull-etcd-unit-test-386

k8s-ci-robot commented 2 weeks ago

@ArkaSaha30: The /retest command does not accept any targets. The following commands are available to trigger required jobs:

Use /test all to run all jobs.

In response to [this](https://github.com/etcd-io/etcd/pull/18840#issuecomment-2458773382): >/retest pull-etcd-unit-test-386 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
ArkaSaha30 commented 2 weeks ago

/retest-required

ivanvc commented 2 weeks ago

Question, should we squash commits 84096c6 and fdb7302, as technically updating github.com/grpc-ecosystem/grpc-gateway/v2 (84096c6) was the change that updated api/etcdserverpb/gw/rpc.pb.gw.go and therefore caused fdb7302?

ahrtr commented 2 weeks ago

Question, should we squash commits 84096c6 and fdb7302, as technically updating github.com/grpc-ecosystem/grpc-gateway/v2 (84096c6) was the change that updated api/etcdserverpb/gw/rpc.pb.gw.go and therefore caused fdb7302?

@ArkaSaha30 can you please add more context to the commit message for the commit "fix genproto error" for future reference?

ArkaSaha30 commented 2 weeks ago

Question, should we squash commits 84096c6 and fdb7302, as technically updating github.com/grpc-ecosystem/grpc-gateway/v2 (84096c6) was the change that updated api/etcdserverpb/gw/rpc.pb.gw.go and therefore caused fdb7302?

Yes it makes sense to squash it into one commit 👍

ArkaSaha30 commented 2 weeks ago

Question, should we squash commits 84096c6 and fdb7302, as technically updating github.com/grpc-ecosystem/grpc-gateway/v2 (84096c6) was the change that updated api/etcdserverpb/gw/rpc.pb.gw.go and therefore caused fdb7302?

@ArkaSaha30 can you please add more context to the commit message for the commit "fix genproto error" for future reference?

  • Why there is such error?
  • How did you fix the genproto error? manually or automatically?

Yes, I have added it in the dependency management handbooktroubleshooting section. I will raise a PR to elaborate on it.

How did you fix the genproto error? manually or automatically?

It had to be fixed manually by running the [scripts/genproto.sh](https://github.com/etcd-io/etcd/blob/main/scripts/genproto.sh)

ArkaSaha30 commented 2 weeks ago

/retest-required

k8s-ci-robot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ArkaSaha30, ivanvc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/etcd-io/etcd/blob/main/OWNERS)~~ [ahrtr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment