search

etcd-io / etcd

Distributed reliable key-value store for the most critical data of a distributed system
https://etcd.io
Apache License 2.0
47.92k stars 9.78k forks source link

fix: enable int-conversion rule of perfsprint #18859

Open mmorel-35 opened 2 weeks ago

mmorel-35 commented 2 weeks ago

This fixes int-conversion rule from perfsprint

This helps avoid unnecessary memory allocations. It doesn't include server and tests folder as they have a lot of impacted files

k8s-ci-robot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mmorel-35 Once this PR has been reviewed and has the lgtm label, please assign spzala for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/etcd-io/etcd/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 2 weeks ago

Hi @mmorel-35. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
codecov-commenter commented 2 weeks ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 10.52632% with 17 lines in your changes missing coverage. Please review.

Project coverage is 68.81%. Comparing base (0f9c128) to head (24548fc). Report is 2 commits behind head on main.

:exclamation: Current head 24548fc differs from pull request most recent head 1e09dbe

Please upload reports for the commit 1e09dbe to get more accurate results.

Files with missing lines Patch % Lines
etcdctl/ctlv3/command/printer.go 0.00% 11 Missing :warning:
etcdutl/etcdutl/printer.go 0.00% 6 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files | [Files with missing lines](https://app.codecov.io/gh/etcd-io/etcd/pull/18859?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [pkg/report/timeseries.go](https://app.codecov.io/gh/etcd-io/etcd/pull/18859?src=pr&el=tree&filepath=pkg%2Freport%2Ftimeseries.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cGtnL3JlcG9ydC90aW1lc2VyaWVzLmdv) | `91.42% <100.00%> (ø)` | | | [etcdutl/etcdutl/printer.go](https://app.codecov.io/gh/etcd-io/etcd/pull/18859?src=pr&el=tree&filepath=etcdutl%2Fetcdutl%2Fprinter.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZXRjZHV0bC9ldGNkdXRsL3ByaW50ZXIuZ28=) | `0.00% <0.00%> (ø)` | | | [etcdctl/ctlv3/command/printer.go](https://app.codecov.io/gh/etcd-io/etcd/pull/18859?src=pr&el=tree&filepath=etcdctl%2Fctlv3%2Fcommand%2Fprinter.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZXRjZGN0bC9jdGx2My9jb21tYW5kL3ByaW50ZXIuZ28=) | `0.00% <0.00%> (ø)` | | ... and [24 files with indirect coverage changes](https://app.codecov.io/gh/etcd-io/etcd/pull/18859/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) ```diff @@ Coverage Diff @@ ## main #18859 +/- ## ======================================= Coverage 68.80% 68.81% ======================================= Files 420 420 Lines 35532 35532 ======================================= + Hits 24448 24451 +3 + Misses 9662 9657 -5 - Partials 1422 1424 +2 ``` ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/etcd-io/etcd/pull/18859?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/etcd-io/etcd/pull/18859?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Last update [0f9c128...1e09dbe](https://app.codecov.io/gh/etcd-io/etcd/pull/18859?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None).
mmorel-35 commented 2 weeks ago

/assign @ahrtr

ivanvc commented 2 weeks ago

/ok-to-test