search

etcd-io / etcd

Distributed reliable key-value store for the most critical data of a distributed system
https://etcd.io
Apache License 2.0
47.92k stars 9.78k forks source link

build(deps): bump github.com/mgechev/revive from 1.3.9 to 1.5.0 in /tools/mod #18871

Closed dependabot[bot] closed 1 week ago

dependabot[bot] commented 2 weeks ago

Bumps github.com/mgechev/revive from 1.3.9 to 1.5.0.

Release notes

Sourced from github.com/mgechev/revive's releases.

v1.5.0

Changelog

  • e1a4191f40073a040c248b697c5c279db499956a Appending Indicator to the list of projects using Revive. (#1065)
  • 53a111d36eba1335a894b5e35f8ceb4aa240fec2 adds check for receiver names length (#1048)
  • eb18252088841d6c7496c1ce59dbb2818580620a adds filename-format rule (#1092)
  • e9b7f3aa6810c3f2e3c64ee57f58377b4d058c6c bumps go version to 1.21.1 and update dependencies (#1050)
  • 7fa1b2786dee43cdf44ea83e43bad26859a87bd7 chore(deps): update golang docker tag to v1.23 (#1071)
  • 78c3a6c363edb5757ca829c9befa25bf75ac8bfc chore: enable test shuffle and fix TestXDGConfigDirNoFile
  • ad0f03a03f465c81e6ef4acf84a88e33341b4b20 chore: fix typo (#1079)
  • 599874c773fd9579d8d0c6ba7fc79547fb791747 chore: remove unnecessary empty lines (#1080)
  • 1a3d95f6ab37dc674559f3d24e0fbf01665c17eb chore: update actions (#1075)
  • ca2a32b0876585ff7438be1cd37f696ebe1432f6 code cleanup (#1054)
  • 0fc961325794d8c552c4f9c6b2bae8d7548cb98a docs(README): Update the list of contributors (#1076)
  • 8ef730cd03f8c1ceaf181e6dd9d487fcc5e10e6f docs(README): fix TOC, add empty lines (#1074)
  • a213a5f7f6ae68ce555dd18fc8c7582d534af4cf documents default exclusion of vendor
  • 842b3e2fa3665e99bfb56f5d17b000400c4a3e5a enhance Docker build process (#1070)
  • 3bead6f4a09d59a8011588c80b39af8cc7e3a549 feat: add file-length-limit rule (#1072)
  • 501cc4a675053710ba127eba186d38197cfb52f5 feat: ignore vendor if no exclude set (#1058)
  • 4c3641ebc3b87af6c5968fd729e7cbbbcfd2d71a fix #1032 by comparing string representations of types (#1049)
  • 7c068a7ddea336157e6c8b1d424dbc2c54a3d86b fix duplicated findings for string-format when there is more than one… (#1085)
  • 3780c361347fc9870cc623196b698aa85fe7d59e fix(deps): update module github.com/fatih/color to v1.18.0 (#1067)
  • cea28f882a392697a98c1c7026a6099def765d06 fix(deps): update module golang.org/x/tools to v0.26.0 (#1057)
  • fa9af820399d121340506aef367f24f96b47184d fix: change "GO" to "Go" in the use-any rule (#1077)
  • 3249a5ef06e41c4a370fdf1172826b0cd06243cb fix: enforce-repeated-arg-type-style rule finds false positives in case of invalid types (#1046)
  • 511e4e65ffa89c6f657d49236c3aa16e3550e198 fix: extractInstructionFromJSON returns an error (#1082)
  • 798ce218499047f611481fe34c543acd21db2d75 makes exported rule behave as golint (#1051)
  • d29323985f4d2376172ceac40d99531dd0a388f8 refactor: add tests for isGenerated in the lint package (#1083)
  • 21344f1bd526f24aaeb7aa85bc9ae365b7777173 refactor: change to t.Fatal(err) (#1081)
  • 0ac1ef72981537491e26b37f81672b1d0b3687a2 refactor: fix revive.early-return issues (#1087)
  • 7c29b560c3db6959f250fcb5fb69e2a3cf1e7b1d refactor: fix typo in the field name of TestFileFilterRule (#1086)
  • 14babf2824a95a27a0221a7a5afd78d37551b584 refactor: move lint.Name to name.go file (#1084)
  • 2ae682968ff0e6221aa99137b1f55e291c4d397a refactor: remove unused parameter in unexported function (#1096)
  • 6228ba57cff6a007626cbda35f9dfb1249950a47 refactor: simplify tests (#1089)
  • 662e02cd70bfead78bec557fc41fb2c7a777f2fa refactor: use "filepath" instead of "path" (#1073)
  • fa37c00bdffc2c659e4b19525574784277f63c15 removes redefinition of max built-in (#1052)
  • 9a8587cc4922341058ba3113ba81ceb8c667cc67 revive: add revive.toml for linting revive itself (#1094)
  • ff7b0adb4c6e3967640a5a456e3e688c29a467d3 rule.exported: add feature to disable checking on const,method,function, variable (#1047)
  • d76ffb98f6d6001e3286b2d0206df77b653829e5 update testdata: var case (#1055)

v1.4.0

What's Changed

... (truncated)

Commits
  • 78c3a6c chore: enable test shuffle and fix TestXDGConfigDirNoFile
  • 2ae6829 refactor: remove unused parameter in unexported function (#1096)
  • 6228ba5 refactor: simplify tests (#1089)
  • 0fc9613 docs(README): Update the list of contributors (#1076)
  • e1a4191 Appending Indicator to the list of projects using Revive. (#1065)
  • 7c068a7 fix duplicated findings for string-format when there is more than one… (#1085)
  • fa9af82 fix: change "GO" to "Go" in the use-any rule (#1077)
  • 9a8587c revive: add revive.toml for linting revive itself (#1094)
  • eb18252 adds filename-format rule (#1092)
  • 511e4e6 fix: extractInstructionFromJSON returns an error (#1082)
  • Additional commits viewable in compare view


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
k8s-ci-robot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dependabot[bot] Once this PR has been reviewed and has the lgtm label, please assign spzala for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/etcd-io/etcd/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 2 weeks ago

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
codecov-commenter commented 2 weeks ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.67%. Comparing base (e1b4ffb) to head (82c1aa6).

:exclamation: Current head 82c1aa6 differs from pull request most recent head 4667732

Please upload reports for the commit 4667732 to get more accurate results.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files [see 22 files with indirect coverage changes](https://app.codecov.io/gh/etcd-io/etcd/pull/18871/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) ```diff @@ Coverage Diff @@ ## main #18871 +/- ## ========================================== - Coverage 68.78% 68.67% -0.11% ========================================== Files 420 420 Lines 35558 35558 ========================================== - Hits 24459 24421 -38 - Misses 9672 9706 +34 - Partials 1427 1431 +4 ``` ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/etcd-io/etcd/pull/18871?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/etcd-io/etcd/pull/18871?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Last update [e1b4ffb...4667732](https://app.codecov.io/gh/etcd-io/etcd/pull/18871?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None).
ivanvc commented 1 week ago

Closing, indirect. Refer to https://github.com/etcd-io/etcd/blob/main/Documentation/contributor-guide/dependency_management.md#indirect-dependencies

$ find -name go.mod -exec grep -H github.com/mgechev/revive {} \;
./tools/mod/go.mod:     github.com/mgechev/revive v1.3.9 // indirect
dependabot[bot] commented 1 week ago

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.