Enable prow postsubmit jobs

etcd-io / etcd

Distributed reliable key-value store for the most critical data of a distributed system

https://etcd.io

Apache License 2.0

47.89k stars 9.78k forks source link

Enable prow postsubmit jobs #18885

Closed ivanvc closed 16 hours ago

ivanvc commented 1 week ago

What would you like to be added?

After the prow migration, we deleted the CI checks against the main branch. We should restore some of the jobs as postsubmit jobs.

Refer to our current presubmit job configurations and postubmit's

[x] post-etcd-verify (based on pull-etcd-verify)
[x] post-etcd-govulncheck (based on pull-etcd-govulncheck)

Why is this needed?

To improve the code quality, and ensure the main branch doesn't have static analysis issues and vulnerabilities.

ivanvc commented 1 week ago

@jmhbnz, this is the issue we spoke about yesterday. I did a pass on the current presubmit jobs, and we should only enable the two listed before. Please let me know, or update the list with the ones you think should be added (or removed).

After that, we can set it as a good first issue.

jmhbnz commented 1 week ago

/retitle Enable prow postsubmit jobs

jmhbnz commented 1 week ago

Agree the two listed jobs are a great start let's focus on those for now.

samuelbartels20 commented 1 week ago

@ivanvc Please assign me to this ticket, I will get it done

ahrtr commented 1 week ago

/assign @samuelbartels20

Thank you!

samuelbartels20 commented 1 week ago

@ivanvc @ahrtr @jmhbnz Please i have raised a PR for this issue

jmhbnz commented 16 hours ago

Discussed during sig-etcd triage meeting, https://github.com/kubernetes/test-infra/pull/33806 is now merged so @ivanvc should we close this issue now as the new jobs appear to be running nicely https://testgrid.k8s.io/sig-etcd-postsubmits?

ivanvc commented 16 hours ago

Ah, thank you. I wasn't aware of that PR. Closing now, thanks, @samuelbartels20.