search

etcd-io / etcd

Distributed reliable key-value store for the most critical data of a distributed system
https://etcd.io
Apache License 2.0
47.89k stars 9.78k forks source link

[3.4] Backport updating release script to use ssh #18888

Closed jmhbnz closed 1 week ago

jmhbnz commented 1 week ago

Backports commit: b82f882c3d9011bab9da05a6159f701e979b4348 to release-3.4.

We encountered the issue of needing to amend this script manually with this commit diff during release today in order to carry out the release. We originally discussed not backporting this change to release-3.4 because we were not confident how well the script was performing (https://github.com/etcd-io/etcd/pull/17677#discussion_r1545789197). We have now performed several releases with the script carrying out the full release process including pushing tags etc, so I think we should now complete the backport.

cc @ahrtr, @ivanvc

k8s-ci-robot commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/etcd-io/etcd/blob/release-3.4/OWNERS)~~ [ahrtr,jmhbnz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment