search

etcd-io / etcd

Distributed reliable key-value store for the most critical data of a distributed system
https://etcd.io
Apache License 2.0
47.89k stars 9.78k forks source link

Fix displaying etcd logo in README on a dark theme #18891

Closed alexandear closed 6 days ago

alexandear commented 1 week ago

This PR fixes displaying the etcd logo in README.md on a GitHub dark theme.

Before/after screenshots

Before (dark): image After (dark): image Before (light): image After (light): image

See this doc for implementation details.

k8s-ci-robot commented 1 week ago

Hi @alexandear. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
ivanvc commented 1 week ago

/ok-to-test

codecov-commenter commented 1 week ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 6.45161% with 29 lines in your changes missing coverage. Please review.

Project coverage is 68.63%. Comparing base (19aa0db) to head (5ecb6d6). Report is 10 commits behind head on main.

:exclamation: Current head 5ecb6d6 differs from pull request most recent head dd578f4

Please upload reports for the commit dd578f4 to get more accurate results.

Files with missing lines Patch % Lines
server/etcdmain/grpc_proxy.go 6.45% 29 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files | [Files with missing lines](https://app.codecov.io/gh/etcd-io/etcd/pull/18891?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [server/etcdmain/grpc\_proxy.go](https://app.codecov.io/gh/etcd-io/etcd/pull/18891?src=pr&el=tree&filepath=server%2Fetcdmain%2Fgrpc_proxy.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2VydmVyL2V0Y2RtYWluL2dycGNfcHJveHkuZ28=) | `14.52% <6.45%> (-0.53%)` | :arrow_down: | ... and [28 files with indirect coverage changes](https://app.codecov.io/gh/etcd-io/etcd/pull/18891/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) ```diff @@ Coverage Diff @@ ## main #18891 +/- ## ========================================== - Coverage 68.81% 68.63% -0.18% ========================================== Files 420 420 Lines 35532 35558 +26 ========================================== - Hits 24450 24406 -44 - Misses 9658 9720 +62 - Partials 1424 1432 +8 ``` ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/etcd-io/etcd/pull/18891?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/etcd-io/etcd/pull/18891?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Last update [19aa0db...dd578f4](https://app.codecov.io/gh/etcd-io/etcd/pull/18891?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None).
ivanvc commented 1 week ago

Perhaps we should standardize the white background logo with the black version from the CNCF repo? https://github.com/cncf/artwork/tree/main/projects/etcd/horizontal

But we can also keep the color one. I don't have a strong opinion.

jmhbnz commented 6 days ago

/test pull-etcd-integration-1-cpu-amd64

k8s-ci-robot commented 6 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexandear, ivanvc, jmhbnz, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/etcd-io/etcd/blob/main/OWNERS)~~ [jmhbnz,serathius] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment