etcd-io / etcd

Distributed reliable key-value store for the most critical data of a distributed system
https://etcd.io
Apache License 2.0
47.89k stars 9.78k forks source link

Add ivanvc as approver for .github, scripts and tools/rw-heatmaps #18894

Closed jmhbnz closed 1 week ago

jmhbnz commented 1 week ago

Let's recognize the fantastic work @ivanvc has been doing recently.

Of particular note was the recent rework of scripts/release.sh to use gh cli to automate creating GitHub releases. This saved us significant toil last release cycle earlier this week.

Given the excellent work Ivan has been doing in the areas of ci / tooling and his earlier efforts to rewrite tools/rw-heatmaps in golang I think it makes perfect sense for him to be an approver for these areas.

cc @etcd-io/maintainers-etcd

ahrtr commented 1 week ago

Well deserved!

Thanks @ivanvc for the consistent hard work!

Note we can also grant @ivanvc the approver permission for workflows of all projects under sig-etcd.

codecov-commenter commented 1 week ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.75%. Comparing base (19aa0db) to head (3633b43).

:exclamation: Current head 3633b43 differs from pull request most recent head f26f657

Please upload reports for the commit f26f657 to get more accurate results.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files [see 20 files with indirect coverage changes](https://app.codecov.io/gh/etcd-io/etcd/pull/18894/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) ```diff @@ Coverage Diff @@ ## main #18894 +/- ## ========================================== - Coverage 68.81% 68.75% -0.06% ========================================== Files 420 420 Lines 35532 35532 ========================================== - Hits 24450 24429 -21 - Misses 9658 9670 +12 - Partials 1424 1433 +9 ``` ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/etcd-io/etcd/pull/18894?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/etcd-io/etcd/pull/18894?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Last update [19aa0db...f26f657](https://app.codecov.io/gh/etcd-io/etcd/pull/18894?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None).
wenjiaswe commented 1 week ago

+1 Well deserved, thank you Ivan for your great contribution consistently!

k8s-ci-robot commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, jmhbnz, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/etcd-io/etcd/blob/main/OWNERS)~~ [ahrtr,jmhbnz,serathius] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
serathius commented 1 week ago

Thanks @ivanvc, excellent work!