Closed jmhbnz closed 1 week ago
Well deserved!
Thanks @ivanvc for the consistent hard work!
Note we can also grant @ivanvc the approver permission for workflows of all projects under sig-etcd.
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 68.75%. Comparing base (
19aa0db
) to head (3633b43
).:exclamation: Current head 3633b43 differs from pull request most recent head f26f657
Please upload reports for the commit f26f657 to get more accurate results.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
+1 Well deserved, thank you Ivan for your great contribution consistently!
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ahrtr, jmhbnz, serathius
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Thanks @ivanvc, excellent work!
Let's recognize the fantastic work @ivanvc has been doing recently.
Of particular note was the recent rework of
scripts/release.sh
to usegh
cli to automate creating GitHub releases. This saved us significant toil last release cycle earlier this week.Given the excellent work Ivan has been doing in the areas of ci / tooling and his earlier efforts to rewrite
tools/rw-heatmaps
in golang I think it makes perfect sense for him to be anapprover
for these areas.cc @etcd-io/maintainers-etcd