search

etcd-io / etcd

Distributed reliable key-value store for the most critical data of a distributed system
https://etcd.io
Apache License 2.0
47.89k stars 9.78k forks source link

Enable grpc interceptors in serve Context like userHandlers are enabled #18896

Closed nicolaslopezbravo closed 1 day ago

nicolaslopezbravo commented 1 week ago

What would you like to be added?

embed's serve creates a new v3rpc grpc server but doesn't make use of the interceptor option. Could serve context have userInterceptors similar to userHandlers so the user can add & pass in interceptors to the grpc server?

Why is this needed?

Extends existing capability, allows for user to add all sorts of useful middleware, monitoring, auth, etc.

nicolaslopezbravo commented 3 days ago

CC @ahrtr just want to check if this is reasonable, I can implement it if necessary. Is there any permissions required to create a pr?

nicolaslopezbravo commented 1 day ago

Nevermind, this is the feature I was looking for https://github.com/etcd-io/etcd/pull/14066. Sorry I'm a bit new to etcd, are releases scheduled at any particular intervals? Looking to see when v3.6 will be released https://github.com/etcd-io/etcd/blob/main/CHANGELOG/CHANGELOG-3.6.md

jmhbnz commented 1 day ago

Hey @nicolaslopezbravo thanks for your question - for etcd 3.6 we need to address the remaining items in this roadmap: https://github.com/etcd-io/etcd/blob/main/Documentation/contributor-guide/roadmap.md#v360

I'll close this now given the feature is ready and will be published in 3.6.