search

etcd-io / etcd

Distributed reliable key-value store for the most critical data of a distributed system
https://etcd.io
Apache License 2.0
47.89k stars 9.78k forks source link

Add robustness track record section to make tracking easier #18900

Closed serathius closed 6 days ago

serathius commented 6 days ago

cc @ahrtr @jmhbnz @fuweid @siyuanfoundation @MadhavJivrajani

codecov-commenter commented 6 days ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 6.45161% with 29 lines in your changes missing coverage. Please review.

Project coverage is 68.71%. Comparing base (12b47c2) to head (78c969f). Report is 22 commits behind head on main.

:exclamation: Current head 78c969f differs from pull request most recent head 7a81c5f

Please upload reports for the commit 7a81c5f to get more accurate results.

Files with missing lines Patch % Lines
server/etcdmain/grpc_proxy.go 6.45% 29 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files | [Files with missing lines](https://app.codecov.io/gh/etcd-io/etcd/pull/18900?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [server/etcdmain/grpc\_proxy.go](https://app.codecov.io/gh/etcd-io/etcd/pull/18900?src=pr&el=tree&filepath=server%2Fetcdmain%2Fgrpc_proxy.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2VydmVyL2V0Y2RtYWluL2dycGNfcHJveHkuZ28=) | `14.52% <6.45%> (-0.53%)` | :arrow_down: | ... and [21 files with indirect coverage changes](https://app.codecov.io/gh/etcd-io/etcd/pull/18900/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) ```diff @@ Coverage Diff @@ ## main #18900 +/- ## ========================================== + Coverage 68.69% 68.71% +0.02% ========================================== Files 420 420 Lines 35532 35558 +26 ========================================== + Hits 24409 24435 +26 - Misses 9686 9697 +11 + Partials 1437 1426 -11 ``` ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/etcd-io/etcd/pull/18900?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/etcd-io/etcd/pull/18900?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Last update [12b47c2...7a81c5f](https://app.codecov.io/gh/etcd-io/etcd/pull/18900?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None).
k8s-ci-robot commented 6 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, jmhbnz, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/etcd-io/etcd/blob/main/OWNERS)~~ [ahrtr,jmhbnz,serathius] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment