etcd-io / etcd

Distributed reliable key-value store for the most critical data of a distributed system
https://etcd.io
Apache License 2.0
47.89k stars 9.78k forks source link

Reduce QPS requirement to 100 #18928

Open serathius opened 1 day ago

serathius commented 1 day ago

In last robustness meeting Nov 20 https://docs.google.com/document/d/1idZ_7tV6F18v223LyQ0WVUn9gXLSKyeLwYTdAgbjxpw/edit?usp=sharing, we identified that reducing QPS would reduce number of flakes from 10->2

We need a better way to monitor and track qps accross tests

serathius commented 1 day ago

cc @jmhbnz

k8s-ci-robot commented 1 day ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmhbnz, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/etcd-io/etcd/blob/main/OWNERS)~~ [jmhbnz,serathius] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov-commenter commented 1 day ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.72%. Comparing base (4186283) to head (50be651). Report is 4 commits behind head on main.

:exclamation: Current head 50be651 differs from pull request most recent head b85c6ba

Please upload reports for the commit b85c6ba to get more accurate results.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files [see 20 files with indirect coverage changes](https://app.codecov.io/gh/etcd-io/etcd/pull/18928/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) ```diff @@ Coverage Diff @@ ## main #18928 +/- ## ========================================== + Coverage 68.65% 68.72% +0.06% ========================================== Files 420 420 Lines 35558 35558 ========================================== + Hits 24413 24437 +24 + Misses 9715 9694 -21 + Partials 1430 1427 -3 ``` ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/etcd-io/etcd/pull/18928?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/etcd-io/etcd/pull/18928?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Last update [4186283...b85c6ba](https://app.codecov.io/gh/etcd-io/etcd/pull/18928?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None).

🚨 Try these New Features:

serathius commented 1 day ago

And we imminently get a flake. We only got 147 QPS :(

serathius commented 1 day ago

Lowered it down to 100, I think we need to build up instead of getting cut off from the top

serathius commented 1 day ago

/retest