search

etcd-io / jetcd

etcd java client
Apache License 2.0
1.08k stars 314 forks source link

watcher: Expose isClosed method #1360

Closed giri-vsr closed 1 month ago

giri-vsr commented 1 month ago

Expose isClosed method on watcher so that we can restart the watch incase it is closed because of Errors.isHaltError(status) or Errors.isNoLeaderError(status)

giri-vsr commented 1 month ago

@lburgazzoli can you please check this?

lburgazzoli commented 1 month ago

@giri-vsr it would be nice to add a test

giri-vsr commented 1 month ago

@lburgazzoli Thanks. Test and method already exists. Just exposing isClosed method.

Now I have updated the test to access isClosed without casting https://github.com/etcd-io/jetcd/pull/1360/files#diff-5f89a9932256c4646613add04e2b8bd044b71bdd11394f1df0e574fe740015e2

giri-vsr commented 1 month ago

@lburgazzoli anything else required? Also is it possible to do a release after this is merged? Thanks

lburgazzoli commented 1 month ago

@giri-vsr I'll try to do a release this week

giri-vsr commented 1 month ago

Thanks

giri-vsr commented 1 month ago

@lburgazzoli Did you manage to do the release?

lburgazzoli commented 1 month ago

no, will do this week. sorry for the delay

giri-vsr commented 1 month ago

@lburgazzoli No worries.Let me know once it is released Thanks

giri-vsr commented 1 month ago

@lburgazzoli Did you manage to do the release?

lburgazzoli commented 1 month ago

@giri-vsr trying to release, but having issues with nexus/maven central

lburgazzoli commented 1 month ago

0.8.2 should be synced to maven central soon