Closed fanminshi closed 7 years ago
I think we can add a maven goal to do so and a related checkstyle rule to ensure the header is there.
See http://www.mojohaus.org/license-maven-plugin/examples/example-add-license.html
Would the header below be ok:
/**
* Copyright © 2016 CoreOS
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
header looks fine with me. defer @xiang90.
@lburgazzoli @fanminshi changing the copyright to jetcd authors? lgtm other than that.
@xiang90 should the date be 2017 or 2016?
2017 is better
@lburgazzoli Copyright © 2016 CoreOS
=> Copyright 2017 The jetcd authors
follows etcd header convention.
I'm having a small issue now that I'm unable to add an empty line between the license header and the package directive which violates one of the checkstyle rules, so I have temporary disabled checkstyle's EmptyLineSeparator module
@lburgazzoli disable EmptyLineSeparator
is fine with me.
closing. this is done.
Need to add apache 2.0 license to all jetcd related files. Do this after all pending 0.0.1 milestone prs have merged.