Test: Replace t.error/fatal with assert/request in [/tracker/inflights_test.go]

etcd-io / raft

Raft library for maintaining a replicated state machine

Apache License 2.0

630 stars 160 forks source link

Test: Replace t.error/fatal with assert/request in [/tracker/inflights_test.go] #190

Closed MrDXY closed 5 months ago

MrDXY commented 5 months ago

Refactor: Replacing t.Error/t.Fatal with assert/require

This commit tries to eliminate boilerplate code in the testing suite by replacing occurrences of t.Error and t.Fatal with assertions from the assert and require packages.

Changes Made:

Replaced instances of t.Error with assert
Replaced instances of t.Fatal with require

Affected Files:

[/tracker/inflights_test.go]

Part of: #146

ahrtr commented 5 months ago

We need to bump the go version to fix the workflow failure (CVE). FYI. https://github.com/etcd-io/etcd/issues/17703

MrDXY commented 5 months ago

I can work on bumping the go version.

ahrtr commented 5 months ago

I can work on bumping the go version.

Sure, feel free to raise a PR.

MrDXY commented 5 months ago

Hi, folks, since the go version has been bumped, the git workflow should now be functioning smoothly. The PR is all set for a second review. whenever you find a moment, please take a look. Thanks!