search

etcd-io / raft

Raft library for maintaining a replicated state machine
Apache License 2.0
666 stars 164 forks source link

raft: clarify [Memory]Storage entries semantics #45

Closed pav-kv closed 1 year ago

pav-kv commented 1 year ago

This change adds extra protection to slices returned from MemoryStorage, so that any appends to these slices at the raft or application level can be tolerated.

This change also clarifies the semantics of Storage.Entries method to this extent, and touches other aspects like returned errors.

pav-kv commented 1 year ago

@tbg Could you take a look commit-by-commit?

pav-kv commented 1 year ago

@ahrtr PTAL

pav-kv commented 1 year ago

@ahrtr @tbg Thank you both for the reviews! Could you merge please?