search

etcd-io / website

etcd.io
https://etcd.io
Other
146 stars 295 forks source link

docsy submodule needs update #748

Closed sgotand closed 7 months ago

sgotand commented 11 months ago

For https://github.com/etcd-io/website/issues/717, I tried to upgrade huge, but it failed due to docsy theme issue.

Please consider upgrading vendored docsy :)

$ npm run serve

> serve
> netlify dev -c "hugo serve --minify -DFE -w"

◈ Netlify Dev ◈
◈ Ignored general context env var: LANG (defined in process)
◈ Ignored general context env var: LC_ALL (defined in process)
◈ Setting up local development server
◈ Starting Netlify Dev with Hugo
Start building sites …
hugo v0.111.3-5d4eb5154e1fed125ca8e9b5a0315c4180dab192+extended darwin/amd64 BuildDate=2023-03-12T11:40:50Z VendorInfo=gohugoio
ERROR 2023/11/07 17:05:21 render of "page" failed: "/Users/sgotand/workspace/etcd-kubecon/website/themes/docsy/layouts/blog/baseof.html:4:7": execute of template failed: template: blog/single.html:4:7: executing "blog/single.html" at <partial "head.html" .>: error calling partial: execute of template failed: html/template:partials/head.html:27:13: no such template "_internal/google_news.html"
ERROR 2023/11/07 17:05:21 render of "page" failed: "/Users/sgotand/workspace/etcd-kubecon/website/themes/docsy/layouts/blog/baseof.html:4:7": execute of template failed: template: blog/single.html:4:7: executing "blog/single.html" at <partial "head.html" .>: error calling partial: execute of template failed: html/template:partials/head.html:27:13: no such template "_internal/google_news.html"
ERROR 2023/11/07 17:05:21 render of "page" failed: "/Users/sgotand/workspace/etcd-kubecon/website/themes/docsy/layouts/blog/baseof.html:4:7": execute of template failed: template: blog/single.html:4:7: executing "blog/single.html" at <partial "head.html" .>: error calling partial: execute of template failed: html/template:partials/head.html:27:13: no such template "_internal/google_news.html"
ERROR 2023/11/07 17:05:21 render of "page" failed: "/Users/sgotand/workspace/etcd-kubecon/website/themes/docsy/layouts/blog/baseof.html:4:7": execute of template failed: template: blog/single.html:4:7: executing "blog/single.html" at <partial "head.html" .>: error calling partial: execute of template failed: html/template:partials/head.html:27:13: no such template "_internal/google_news.html"
Built in 294 ms
Error: Error building site: failed to render pages: render of "page" failed: "/Users/sgotand/workspace/etcd-kubecon/website/themes/docsy/layouts/blog/baseof.html:4:7": execute of template failed: template: blog/single.html:4:7: executing "blog/single.html" at <partial "head.html" .>: error calling partial: execute of template failed: html/template:partials/head.html:27:13: no such template "_internal/google_news.html"
⠼ Waiting for framework port 1313. This can be configured using the 'targetPort' property in the netlify.toml◈ Command failed with exit code 255: hugo serve --minify -DFE -w. Shutting down Netlify Dev server
jmhbnz commented 11 months ago

@nate-double-u a quick note I was able to hackily work around this locally by:

  1. npm install
  2. Deleting the line {{- template "_internal/google_news.html" . -}} from themes/docsy/layouts/partials/head.html.
  3. npm run serve

It looks like that same change was done upstream in cncf/docsy under https://github.com/cncf/docsy/commit/784efae528d062126e187f4933529716b135c421.

nate-double-u commented 7 months ago

fixed by https://github.com/etcd-io/website/pull/803