search

etcd-io / website

etcd.io
https://etcd.io
Other
144 stars 292 forks source link

Update grpc_naming.md for Using etcd discovery with go-grpc code example #871

Closed Aaron-cdx closed 2 months ago

Aaron-cdx commented 2 months ago
  1. fix current code example's errors in import and usage
k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Aaron-cdx Once this PR has been reviewed and has the lgtm label, please assign nate-double-u for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/etcd-io/website/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Aaron-cdx commented 2 months ago

hi master @jmhbnz, I close this PR and raised a new PR for this, thank you!