search

etcd-io / website

etcd.io
https://etcd.io
Other
144 stars 292 forks source link

fix: update grpc_naming.md for using etcd discovery with go-grpc code… #873

Closed Aaron-cdx closed 2 months ago

Aaron-cdx commented 2 months ago

hi @jmhbnz, thanks for your reminder, I removed the changes for 3.3 and checked and added the changes for 3.4 & 3.5 & 3.6.

jmhbnz commented 2 months ago

hi @jmhbnz, thanks for your reminder, I removed the changes for 3.3 and checked and added the changes for 3.4 & 3.5 & 3.6.

Thanks - Can you please ensure your commit is signed so the Developer Certificate of Origin check passes? i.e

git reset --soft HEAD~1
git commit --signoff -m "<message>"
git push --force
Aaron-cdx commented 2 months ago

hi @jmhbnz, thanks for your reminder, I removed the changes for 3.3 and checked and added the changes for 3.4 & 3.5 & 3.6.

Thanks - Can you please ensure your commit is signed so the Developer Certificate of Origin check passes? i.e

git reset --soft HEAD~1
git commit --signoff -m "<message>"
git push --force

Hi @jmhbnz completed, please help to check, thank you!

k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Aaron-cdx, ivanvc, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/etcd-io/website/blob/main/OWNERS)~~ [jmhbnz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment