search

etcd-io / website

etcd.io
https://etcd.io
Other
144 stars 292 forks source link

add partial for version banner #900

Closed moficodes closed 1 week ago

moficodes commented 2 weeks ago
moficodes commented 1 week ago

@jmhbnz

jmhbnz commented 1 week ago

I am still seeing that v3.4 is showing up in the deploy preview as having the deprecation banner? https://deploy-preview-900--etcd.netlify.app/docs/v3.4/

v3.4 is still supported so should not have the banner, please let me know if I am missing something.

moficodes commented 1 week ago

There was is_deprecated flag set on 3.4 removed in the latest commit.

ivanvc commented 1 week ago

This change looks good to me. One thing worth noting is that the v3.6 docs now show a warning, too. I think it should be fine, but I just wanted to raise awareness of it.

https://deploy-preview-900--etcd.netlify.app/docs/v3.6/

k8s-ci-robot commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivanvc, jmhbnz, moficodes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/etcd-io/website/blob/main/OWNERS)~~ [jmhbnz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment